Unfortunately, solving this implies changes to the binary dist (although only in unit test code).
Mike: I'll check in the change -- for you to decide which release to include it in.
-- Salut,
Jordi.
Jeremy Arnold wrote:
Jordi,
I took a quick look at the test failure log. I suspect that you are correct that the problem is that the tests are executed in a different order. PackageTest apparently assumes that the variables are already set. I haven't tried to check what order the tests are executed in with the binary distribution, but I see that there are at least a couple of tests (org.apache.jmeter.engine.util.ValueReplacer.Test, org.apache.jmeter.extractor.RegexExtracter.Test) which initialize the variables, and a couple other places in the JMeter code that initialize them. The best way to fix this is probably for PackageTest to initialize the variables itself. That way the tests can run in any order without problems.
Regarding the missing lib/ant*.jar and other missing libraries: isn't part of the point of having a source distribution that it doesn't have all the extra binaries, so you have to either already have them or download them separately? I just checked the source distributions for Tomcat and Commons-HttpClient and neither includes Ant -- they just have a BUILDING.txt that describes what you need to build it.
I agree that we should consider Maven for 1.10 -- a couple months ago I played with building JMeter with Maven, and it seemed to work pretty well, especially since we're building multiple jar files.
Jeremy
Jordi Salvat i Alabart wrote:
Hi Mike. Hi everyone.
"./build.sh src_dist" has some problems (in addition to the one I described in my previous message). Enumerating them here for discussion:
- The src distribution needs to be unpacked on top of the binary distribution -- otherwise the libraries in lib/ will be missing. Do you think they should be in both packages?
- log4j.conf is missing form bin/. This doesn't seem to break any tests -- are they needed?
- bin/testfiles/ is missing -- this is required for tests to work.
- lib/ant-...jar and lib/ant-...-optional.jar are missing. They should be in the source package.
- build.sh lacks the necessary execute permissions. I should add these.
- There's no way to build binary and source distributions in a single shot -- you need to build one, extract the results, then build the other. I should fix this.
I can fix all these without need to re-issue the binary distribution. Or we can generate a source distribution by hand (by packing up the checked-out CVS content) and sort these out later: for 1.9.1 if Mike decides to issue it for the Japanese stuff, or for 1.10. It's also possible that we need to issue a 1.9.1 anyway to sort out the unit test problem from my previous e-mail. Your opinion welcome.
For 1.10, we could try to move to Maven for building. Seems to be pretty much the standard chez Jakarta. Anyone has experience with it?
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
-- Salut,
Jordi.
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
