This sounds like a good idea. I would really like to see a way of making this clearer to read for future programmers as well. If this is going to undergo a major refactoring we should put some thought into organizing the constants in a way that makes it easy to find those you are interested in, without have a good idea what they are called. I think we just need to categorize them more carefully.
Jonathan On Aug 2, 2011, at 1:03 PM, Nicolas Vervelle wrote: > Hi, > > Looking at JmolConstants, I think we could refactor it to have much cleaner > code in Jmol. > I think especially about the list of constants. > Since we are now using Java 5 code, what do you think about using Enum ? > > For example, replacing all the CALLBACK_xxx constants and callbackNames[] by > an proper Enum in its own file ? > And then only using the Enums in the rest of the code. > I think it will be cleaner and a lot better for type safety. > > Nico > ------------------------------------------------------------------------------ > BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA > The must-attend event for mobile developers. Connect with experts. > Get tools for creating Super Apps. See the latest technologies. > Sessions, hands-on labs, demos & much more. Register early & save! > http://p.sf.net/sfu/rim-blackberry-1 > _______________________________________________ > Jmol-developers mailing list > Jmol-developers@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jmol-developers Dr. Jonathan H. Gutow Chemistry Department gu...@uwosh.edu UW-Oshkosh Office: 920-424-1326 800 Algoma Boulevard FAX:920-424-2042 Oshkosh, WI 54901 http://www.uwosh.edu/facstaff/gutow ------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1 _______________________________________________ Jmol-developers mailing list Jmol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jmol-developers
