On Mon, 11 Mar 2024 10:09:28 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> The deprecated Subject Delegation feature in JMX will be removed. >> >> This was marked in JDK 21 as deprecated for removal (JDK-8298966). > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > (C) oops src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnection.java line 126: > 124: * @param className The class name of the MBean to be instantiated. > 125: * @param name The object name of the MBean. May be null. > 126: * @param delegationSubject No longer supported and should be null. I think it can be simplified to: Suggestion: * @param delegationSubject must be {@code null}. I see no need to mention this feature no longer supported as no one is using and will use this feature. Same comment applies to all methods that take `delegationSubject`. src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnection.java line 157: > 155: * @throws IOException if a general communication exception occurred. > 156: * @throws UnsupportedOperationException if a non-null > delegationSubject > 157: * is specified. Subject Delegation has been removed. This can be simplified to: Suggestion: * @throws UnsupportedOperationException if {@code delegationSubject} is non-null Same comment applies to all methods that take `delegationSubject`. src/java.management/share/classes/javax/management/remote/JMXConnector.java line 139: > 137: /** > 138: * <p>This method remains for compatibility reasons, but has no more > meaning > 139: * than {@link #getMBeanServerConnection()}. Suggestion: * <p>This method is equivalent to calling {@link #getMBeanServerConnection()}. src/java.management/share/classes/javax/management/remote/JMXConnector.java line 142: > 140: * > 141: * @param delegationSubject must be null, since the removal of the > 142: * Subject Delegation feature. Suggestion: * @param delegationSubject must be {@code null} src/java.management/share/classes/javax/management/remote/JMXConnector.java line 153: > 151: * > 152: * @exception UnsupportedOperationException if a non-null > delegationSubject > 153: * is specified. Subject Delegation has been removed. Suggestion: * @exception UnsupportedOperationException if {@code delegationSubject} is non-null. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18025#discussion_r1520188392 PR Review Comment: https://git.openjdk.org/jdk/pull/18025#discussion_r1520183154 PR Review Comment: https://git.openjdk.org/jdk/pull/18025#discussion_r1520165902 PR Review Comment: https://git.openjdk.org/jdk/pull/18025#discussion_r1520166471 PR Review Comment: https://git.openjdk.org/jdk/pull/18025#discussion_r1520170490