I think you misunderstood me. Simply accessing the frameElement property from a frame that isn't on the same domain as the parent frame causes an exception to be thrown.
Previously the check was: !window.frameElement Which was not enough - it completely breaks use of jQuery. There needs to be a new check. Granted, the typeof one appears to be too extreme but the previous one was broken, as well (and in a much worse way). --John On Tue, Jan 27, 2009 at 11:18 AM, Diego Perini <diego.per...@gmail.com> wrote: > > John, > well the reasons are ok, but the method is wrong in fact the doScroll > () trick is actually short-circuited and will never be usable neither > in iframes nor on the main document. So in IE everything will be > started by the "onreadystatechange" event...a bit too late. > > Diego > > > On 27 Gen, 20:09, John Resig <jere...@gmail.com> wrote: >> That check, alone, is not sufficient, though. We were hitting a number >> of ugly exceptions with IE - when dealing with cross-domain frames. >> >> http://dev.jquery.com/ticket/3880 >> >> In this commit:http://dev.jquery.com/changeset/6120 >> >> So some alternative solution will need to be derived - especially >> since getting the exceptions was far worse (the page didn't load, at >> all). >> >> --John >> >> On Tue, Jan 27, 2009 at 11:00 AM, Diego Perini <diego.per...@gmail.com> >> wrote: >> >> > John, >> > the report is OK and says the truth...Mexicans would say "ay ay >> > ay !!!". >> >> > This is something that should have been avoided...a too critical place >> > to play with. >> >> > The problem I see is that my patch and test for iframes got changed: >> >> > Line 2952 is currently: >> >> > if ( document.documentElement.doScroll && typeof window.frameElement >> > === "undefined" ) (function(){ >> >> > This will always exclude the doScroll() magic. >> >> > When does the type of that property assumes an "undefined" type ? I >> > would bet for "never" ? >> >> > That property can be "null" which is an "object" not an "undefined" >> > value. Please fix that a.s.a.p. to avoid further problems and wrong >> > reports. >> >> > I would take my part of responsibility for not having checked that, >> > but releases are so fast I didn't even know a 1.3.1 was already >> > available. >> >> > Diego >> >> > On 27 Gen, 17:24, John Resig <jere...@gmail.com> wrote: >> >> Do you have a demo page that we can look at? >> >> >> --John >> >> >> On Fri, Jan 23, 2009 at 11:01 AM, helianthus >> >> >> <project.heliant...@gmail.com> wrote: >> >> >> > 1.2.6: >> >> > No problems on all browsers tested. >> >> > 1.3.1: >> >> > IE7 & IE8 beta2: Fires only after all images are completely loaded. >> >> > FF3, Opera 9, Chrome: Fires right after DOM is loaded. > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jQuery Development" group. To post to this group, send email to jquery-dev@googlegroups.com To unsubscribe from this group, send email to jquery-dev+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/jquery-dev?hl=en -~----------~----~----~----~------~----~------~--~---
