I confirm that jQuery.isObjectLiteral(document.createElement("div")) returns
true under IE8.2009/12/2 Julian Aubourg <aubourg.jul...@gmail.com> > I started cleaning the code and I think it's already in a good enough shape > now for some code reviews/remarks/ideas, etc. > All tests pass under webkit browsers, Opera & Firefox (only latest versions > tested). IE8 has two failing tests (3 but the third doesn't fail if the 2 > previous ones aren't ran) I haven't tested in previous versions. > > This bug is quite fun in fact. It seems there is a problem in the deep copy > algorithm when there is an object of type "DispHTMLDocument" (according to > IE's debugger) when trying to access its "fileCreatedDate" field (line 268 > of core.js) : we get a marvellous "unspecified error". Anyway, it means > putting a context option in the ajax option object makes it fail at the very > first line of $.ajax. Can anybody confirm it also happens on the master > under IE8? At first I thought it was because of the new options I put in > ajaxSettings but, unless there's some crazy side-effect involved here, it's > quite unlikely. > > I suppose this is related to the discussion regarding spotting real object > litterals to avoid this kind of mess. Strange thing is, only IE has a > problem with it and I was wondering if there was a non-standard way to spot > built-in types to circumvent it? > > Anyway, I need to implement cross-domain tests (so that I can confirm the > addition of XDomainRequest support). > > -- Julian > > 2009/12/2 John Resig <jere...@gmail.com> > > Phew - this is a beast of a patch indeed! In general though I'm liking >> the feel of the resulting code, a lot. This would be much more >> extensible, which is quite nice. I say we try to pursue this post-1.4. >> >> In the meantime you can start to apply some of the jQuery Core Style >> Guidelines to your code to get it ready for inclusion: >> http://docs.jquery.com/JQuery_Core_Style_Guidelines >> >> Naturally, making sure that all the tests pass as well is a great way >> to make sure that the code lands. >> >> --John >> >> >> >> On Tue, Dec 1, 2009 at 8:21 PM, Julian Aubourg <aubourg.jul...@gmail.com> >> wrote: >> > Thanks Dave but I think I kinda figured it out! >> > >> > Anyway, the code has been comitted at http://github.com/jaubourg/jquery >> > >> > I don't have time to write everything about it down right now but you >> can >> > all have a look at least. >> > >> > 2009/12/2 Dave Methvin <dave.meth...@gmail.com> >> >> >> >> > OK, so I have implemented my solution: >> >> >> >> > Anyway, for the time being, my branch is sitting on my harddrive. >> Why? >> >> > Well, >> >> > I've been practicing source control for years now but I have to admit >> I >> >> > never encountered something as cryptic and unfriendly as git. >> >> >> >> > So, if anyone has clear step in order to commit with this zealot, >> please >> >> > do >> >> > share before I commit suicide. I made a fork of jQuery on github btw. >> >> >> >> Julian, I'm still coming up to speed with Git on Windows myself, and >> >> stuck at trying to push my changes back to my fork on Github. I'm >> >> going to start a new thread here about it. >> >> >> >> -- >> >> >> >> You received this message because you are subscribed to the Google >> Groups >> >> "jQuery Development" group. >> >> To post to this group, send email to jquery-...@googlegroups.com. >> >> To unsubscribe from this group, send email to >> >> jquery-dev+unsubscr...@googlegroups.com<jquery-dev%2bunsubscr...@googlegroups.com> >> . >> >> For more options, visit this group at >> >> http://groups.google.com/group/jquery-dev?hl=en. >> >> >> >> >> > >> > -- >> > >> > You received this message because you are subscribed to the Google >> Groups >> > "jQuery Development" group. >> > To post to this group, send email to jquery-...@googlegroups.com. >> > To unsubscribe from this group, send email to >> > jquery-dev+unsubscr...@googlegroups.com<jquery-dev%2bunsubscr...@googlegroups.com> >> . >> > For more options, visit this group at >> > http://groups.google.com/group/jquery-dev?hl=en. >> > >> >> -- >> >> You received this message because you are subscribed to the Google Groups >> "jQuery Development" group. >> To post to this group, send email to jquery-...@googlegroups.com. >> To unsubscribe from this group, send email to >> jquery-dev+unsubscr...@googlegroups.com<jquery-dev%2bunsubscr...@googlegroups.com> >> . >> For more options, visit this group at >> http://groups.google.com/group/jquery-dev?hl=en. >> >> >> > -- You received this message because you are subscribed to the Google Groups "jQuery Development" group. To post to this group, send email to jquery-...@googlegroups.com. To unsubscribe from this group, send email to jquery-dev+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/jquery-dev?hl=en.
