[
https://issues.apache.org/jira/browse/JSPWIKI-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533502#comment-13533502
]
Juan Pablo Santos RodrÃguez commented on JSPWIKI-651:
-----------------------------------------------------
Hi Glen,
thanks a lot for the poms! :-)
At the very least, with all the dependencies listed in there, will allow us at
least to upload jspwiki.jar and jspwiki.war to Apache's Nexus (and then Maven
Central). I've run a mvn clean test and I've got a lot of test errors, but they
fail with "Unable to locate test property resource: /jspwiki.properties" so
most probably it's something you have placed in test/resources?
Regarding the PluginManager issue, is it /ini/classmappings.xml on classpath?
It took a me a while to realize this and add the appropiate entrance to
.classpath, so the tests could run inside Eclipse. Take a look at ClassUtil, it
is called at WikiEngine#initialize()
I'm very interested on seeing the Maven integration. I haven't stopped at it
because I'd preferred to modularize the source first, so when it comes to Maven
it's a no-brainer to split the code in several modules, effectively having one
jspwiki-api-VERSION.jar, jspwiki-plugins-VERSION.jar, etc.
As for the layout of the project, in my experience with Maven the following
structure has worked reasonible well:
1.- builder.pom: builds all the project; includes all the <*management/> stuff
except dependencies
1.1.- dependencies 2 submodules (main dependencies and test dependencies) with
the appropiate dependencies and dependenciesManagement sections, so we can
refer to dependencies in the rest of the build with only groupId and artifactId:
1.2.- main build: a pom with several sub-modules, for example
1.2.1.- jspwiki-api
1.2.2.- jspwiki-core
1.2.3.- jspwiki-i18n
1.2.4.- jspwiki-utils
1.2.5.- jspwiki-plugins
1.2.6.- jspwiki-test-infra (for TestWikiEngine and associateds)
...
1.2.X.- jspwiki-war (includes all the former ones)
1.2.X+1 - jspwiki-IT
I think it would be easier to build up that structure and push the code in
there rather than adapting the pom. WDYT?
> Convert JSPWiki to a Maven project
> ----------------------------------
>
> Key: JSPWIKI-651
> URL: https://issues.apache.org/jira/browse/JSPWIKI-651
> Project: JSPWiki
> Issue Type: Improvement
> Reporter: Daniel Johansson
> Priority: Trivial
> Labels: ant, build, ivy, maven
> Attachments: pom.xml, pom.xml
>
>
> Hello there, I was hoping to maybe one day contribute to the JSPWiki project
> and after having checked out the trunk code and played around somewhat I was
> thinking it would be very nice if this project used Maven.
> I'm sure most of you are familiar with Maven in one way or another, you might
> even have a really good reason for not doing this to JSPWiki.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
