[ 
https://issues.apache.org/jira/browse/JSPWIKI-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533519#comment-13533519
 ] 

Glen Mazza commented on JSPWIKI-651:
------------------------------------

Juan, two issues: 
1.) During testing, Maven adds the resources in the "runtime" 
(src/main/resources) to the resources in the "testtime" (src/test/resources) 
and I just declared them both (see my resources and testresources declarations 
under the <build> element, I don't know which jspwiki.properties is taking 
effect (presumably Maven would use the test one automatically).  That's 
normally not a problem with Maven projects (run & test-time resources should be 
mergable just like run & test-time Java classes are) but that might cause an 
early hiccup with us, as we're not expecting the merging of run-time and 
test-time resources during testing.

2.) The Ant build.xml does further configuration of the jspwiki.properties file 
prior to running the tests (propertiesfile task), Maven does not have this 
configuration, it's running that file raw.  Your Ant compile may be helping 
because it causes those extra values to get into the jspwiki.properties file, 
that Maven is subsequently using. Two solutions: to create a fully populated 
test "jspwiki.properties" that is used as-is (either Maven or Ant) without 
additional elements added in by Ant, or: Maven always has an Ant Run plugin 
that can be used to call Ant build scripts (as well as include Ant targets if 
desired):  http://maven.apache.org/plugins/maven-antrun-plugin/.  The Ant Run 
plugin is usually a helpful crutch for projects in the process of Mavenizing 
but still have very complex functionality in Ant scripts that need to be used.

Even if we never get to use Maven, it still helps in modularizing JSPWiki -- 
Maven helps show which dependencies and resources we don't need and we can 
simplify the Ant build.xml as a result, also if we can stop doing the test file 
configuration in build.xml (as mentioned in #2 above) that also gives us more 
portability/independence across build tools.
                
> Convert JSPWiki to a Maven project
> ----------------------------------
>
>                 Key: JSPWIKI-651
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-651
>             Project: JSPWiki
>          Issue Type: Improvement
>            Reporter: Daniel Johansson
>            Priority: Trivial
>              Labels: ant, build, ivy, maven
>         Attachments: pom.xml
>
>
> Hello there, I was hoping to maybe one day contribute to the JSPWiki project 
> and after having checked out the trunk code and played around somewhat I was 
> thinking it would be very nice if this project used Maven.
> I'm sure most of you are familiar with Maven in one way or another, you might 
> even have a really good reason for not doing this to JSPWiki.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to