[
https://issues.apache.org/jira/browse/JSPWIKI-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538818#comment-13538818
]
Glen Mazza commented on JSPWIKI-651:
------------------------------------
Hi latest changes to the pom (you may delete the older one--delete permissions
aren't working for older JIRA items apparently):
1.) Added in three dependencies with <scope>runtime</scope> -- those used in
deployment but not compilation (nekohtml, taglibs, commons-io).
2.) Under <build>, refined the <resources> to exactly those that get placed in
the JSPWiki.jar by the Ant build process.
3.) Under <build>, refined the <testResources> to exactly those needed to run
the unit tests.
4.) Declared maven-surefire-plugin and placed the two failing tests
(WikiEngineTest and AclImplTest) in exclusions for the time being. (Both look
to be minor issues with the jspwiki.properties.)
5.) Maven now creates a shell WAR with the necessary JARs and classes but none
of the non-code resources yet. An upcoming step is to compare the Ant WAR vs.
the Maven WAR and making sure they're identical.
6.) In the shell WAR, Maven presently just copies the compiled JSPWiki classes
and puts them under WEB-INF/classes instead of the Ant WAR which has
lib/JSPWiki.jar. Either way should work, but the Ant way is cleaner. We'll
probably need to move to multiple poms to first generate a JSPWiki.jar that can
be placed into the JSPWiki.war.
Right now, "mvn clean install" will run all the tests (except the two excluded
above) and then create the WAR. However, one must run "ant tests" first so
that the etc/WEB-INF/web.xml is created with the proper values. I think the
next step for Mavenization is to create two additional concrete web.xmls (for
unit and web tests) and have the Ant build script use them (instead of tweaking
the production one), so we can have Maven use those concrete web.xmls as well.
(Unless we want to use the maven-antrun-plugin and do all that modification in
the pom.xmls--but I think just using separate web.xmls are cleaner.) Presently
the Ant build script takes the web.xml for production and modifies it twice to
create test and web-test versions.
> Convert JSPWiki to a Maven project
> ----------------------------------
>
> Key: JSPWIKI-651
> URL: https://issues.apache.org/jira/browse/JSPWIKI-651
> Project: JSPWiki
> Issue Type: Improvement
> Reporter: Daniel Johansson
> Priority: Trivial
> Labels: ant, build, ivy, maven
> Attachments: pom.xml, pom.xml
>
>
> Hello there, I was hoping to maybe one day contribute to the JSPWiki project
> and after having checked out the trunk code and played around somewhat I was
> thinking it would be very nice if this project used Maven.
> I'm sure most of you are familiar with Maven in one way or another, you might
> even have a really good reason for not doing this to JSPWiki.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
