Hey, I don't know if this bugs everyone or just me but it happens very
often that I am working while people are reviewing my code on gh. While
people is reviewing and commenting on the code I keep getting mails and the
diff page from the pr keeps changing. To know when its all done and I can
finally try to answer/fix all the comments I usually wait until my phone
stops ringing madly with mails but I think that we could do better. At the
end of the diff page there is a comment box where you can add comments
(where you usually add your $$merge$$ or LGTM) We could add something
there, like "Done" just to let the author know we are done with the review
and not just reading a big confusing chunk of code.
What do you people think?
-- 
Juju-dev mailing list
Juju-dev@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/juju-dev

Reply via email to