-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 19.09.2014 03:32, David Cheney wrote: > There were three problem reviewboard was supposed to address, > review comments are sent immediately, no side by side diffs, and no > way to to chained proposals. > > I think that over the last few months we've all learnt to live > with the first issue > > On the second, github now does nice side by side diffs. > > On the third, it appears reviewboard leaves you solidly to your > own devices to implement chained proposals. > > I'm with Jesse, I vote to stop using reviewboard, I don't think > it's paying it's way. +1, Due to all the steps you need (to automate) in order to post the review correctly, you're on your own w.r.t. chained diffs, finally the annoying web UI win non-obvious and ways of doing things; I'm a bit disappointed at what RB brings more than just using GitHub PRs.
> > > On Fri, Sep 19, 2014 at 10:19 AM, Jesse Meek > <jesse.m...@canonical.com> wrote: >> We moved to GitHub in the hope of lowering the bar to >> contributors outside the team. GitHub is *the* platform and >> process for open source software. This was the logic behind the >> move. It was deemed to have the most mindshare and we sacrificed >> our prefered platform and process to be part of that mindshare. >> >> We are now leaving that 'main stream' process to something that >> suits the tastes of our team - ReviewBoard. This adds friction >> for new contributors (friction everyone has experienced this >> week). If we value our preferred methods of reviewing over >> keeping to a well known process for outside contributors, the >> best process was launchpad + rietveld. Shouldn't we simply return >> to that. >> >> Considering we have been successfully using GitHub for several >> months now, using reviewboard is not a necessity. Obviously, I >> will go with whatever the team decides, but I'm concerned that we >> have moved to reviewboard without considering that it undermines >> (as far as I can see) our primary reason for using GitHub. >> >> Jess >> >> -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify >> settings or unsubscribe at: >> https://lists.ubuntu.com/mailman/listinfo/juju-dev > - -- Dimiter Naydenov <dimiter.nayde...@canonical.com> juju-core team -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUG+WLAAoJENzxV2TbLzHwbw8H/3a7LlCW4FUYsGklM2/P78+q 8KpjZkNrbSD4PY9CGuRIcOKrT40VCJXMuMlfsaXyIXPktD+zTQGjAjlFMAXaA5El LUmRIwL4vHJuioNerkTBlgyzWqsyl8KA0M1IKilga+GQk7hhEvPcmWLBQI+Qniz2 +GvjG4xUb+QSsFpL3TIbZC8vMu0vsFU3N73v5LTxhxh3udr0AM8dHBHIuVcMHXMF 1nAs4DbIBDSKoJ5e7vvnKn/h6XiBP2iJNwWZBwnjpKEwXW8fSX7vR16CQDOQd4Pd 3KiDTMc1qC32SqAfpvoOc9oEJad0r/+xFvV1phBAS9X5ry3AuBpOHmDiPB/EwCA= =n7u4 -----END PGP SIGNATURE----- -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
