Salut Michael > Indeed, I have committed the change about one week ago. mhm.. I have not seen them at the svn-mail list but you are right! I can see it in the SVN History (5.May). Sorry... looks like I need to check the mail list settings?
> I think I'll do also the second change proposed by jukko before the end > of the week as no one has reacted. Ok.. I actually commited the changes except for Uwe's PostGIS plugin. I wrote him today an email, as I needed somebody to check a build of this Plugin that I have done with Ant (Eric switched to Maven) and I don't have PostGIS installed. So if Uwe replys positively I/You can add the last patch. > > Thanks for all the improvements you have done the few last months. > Thanks also to Uwe for its new tutorial (is there any plan for an > english translation ?) very good question... The plan exists. But it is rather a question of time. I thought I would start with the PostGIS chapter first. And then later ... However, You know as me how much effort (and good will) it takes ;) thank you too Stefan > Michaël > > > Stefan Steiniger a écrit : >> huhu? question again: >> Are you commiting it Larry? or Michael? As you both have done the work.. >> Otherwise people that check the sourceforge statistics think I do all >> the stuff. >> >> However, I can do it if you are too busy :) >> Stefan >> >> Stefan Steiniger schrieb: >> >>> great! >>> >>> thank you Larry and Michael. >>> @Michael: would you do the commit? >>> >>> stefan >>> >>> Larry Becker wrote: >>> >>>> Hi Michaël, >>>> >>>> Thanks for the testing. It sounds like this code change is ready to >>>> be committed. Also, thanks to your instructions, I was able to >>>> construct island multipolygons and test reading them as shapefiles. >>>> They appear to work, even inside CW holes. >>>> >>>> If any Geotools or uDig people are watching this thread, you might >>>> want to consider some changes to your shapefile reader. Not only will >>>> it not read polygons with clockwise holes, but it defaults everything to >>>> multipolygons, even in files with single shells. >>>> >>>> regards, >>>> Larry Becker >>>> >>>> On Sat, May 3, 2008 at 3:59 PM, Michael Michaud <[EMAIL PROTECTED] >>>> <mailto:[EMAIL PROTECTED]>> wrote: >>>> >>>> Hi, Larry, >>>> >>>> I did some tests today with your new PolygonHandler. >>>> I had no file known for the specific problem the new class is supposed >>>> to solve, but I tried to load several files with more or less valid >>>> geometries. >>>> >>>> Most shapefiles have been read exactly the same way with the old code >>>> and with the new code. >>>> >>>> The only one with a different result was a big shapefile with many kind >>>> of valid and invalid polygons (37128 polygons) >>>> old code : 37128 objects imported, including 22 empty >>>> GeometryCollections (shapes that the parser could not read) >>>> new code : 37128 objects imported, including 20 empty >>>> GeometryCollections (shapes that the parser could not read) >>>> I cannot say much about the two polygons new new parser could read >>>> except that one is self intersecting (the other is just simple!). >>>> Indeed, the imported polygon have probably been repaired by the >>>> importer, because if I export them again into shapefile, then I can >>>> read >>>> them with the old PolygonHandler. >>>> >>>> I cannot do much more at home, I'll try to import this shapefile with >>>> arcgis to try to go a step further. >>>> >>>> Anyway, the new PolygonHandler can read a little more than the old one, >>>> and that's what it it supposed to do ;-) >>>> (I'm just curious about the 20 objects it still could not read) >>>> >>>> I did not benchmark the tests, but I did not notice slowdown. >>>> >>>> Michaël >>>> >>>> >>>> Larry Becker a écrit : >>>> > Hi Michaël, >>>> > >>>> > I found another problem with the PolygonHandler routines I copied >>>> from >>>> > geotools. It causes MultiPolygons to be created by default >>>> instead of >>>> > simple Polygons. I restored the original code and inserted the >>>> > modifications for clockwise holes. Now it is a much less radical >>>> change. >>>> > >>>> > Note that I haven't committed any changes to OpenJump yet, only >>>> SkyJUMP. >>>> > >>>> > regards, >>>> > Larry >>>> > >>>> > On Sun, Apr 20, 2008 at 2:12 PM, Larry Becker >>>> <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> >>>> > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>> >>>> wrote: >>>> > >>>> > Hi Michaël, >>>> > >>>> > I've attached OJ's updated PolygonHandler for your review. It >>>> is >>>> > a fairly radical change so exhaustive testing of shapefile >>>> loading >>>> > is recommended. >>>> > >>>> > regards, >>>> > Larry >>>> > >>>> > >>>> > On Fri, Apr 18, 2008 at 3:43 PM, Michaël Michaud >>>> > <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> >>>> <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>> >>>> wrote: >>>> > >>>> > Hi, Larry >>>> > >>>> > I'm glad if I could help, thanks again for the hard work. >>>> > It seems that you found a way to keep both correctness and >>>> > performance. >>>> > If you think you can commit, I am very confident. >>>> > I'll be able to do more tests with complex polygons (but not >>>> > with CW holes). >>>> > >>>> > Note : you can create a MultiPolygon with an island by >>>> > selecting the two >>>> > polygons, then right click and run Combine Selected >>>> Features. >>>> > >>>> > Regards, >>>> > >>>> > Michaël >>>> > >>>> > >>>> > >>>> > >>>> >>>> ------------------------------------------------------------------------- >>>> > This SF.net email is sponsored by the 2008 JavaOne(SM) >>>> Conference >>>> > Don't miss this year's exciting event. There's still time to >>>> > save $100. >>>> > Use priority code J8TL2D2. >>>> > >>>> >>>> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone >>>> > _______________________________________________ >>>> > Jump-pilot-devel mailing list >>>> > Jump-pilot-devel@lists.sourceforge.net >>>> <mailto:Jump-pilot-devel@lists.sourceforge.net> >>>> > <mailto:Jump-pilot-devel@lists.sourceforge.net >>>> <mailto:Jump-pilot-devel@lists.sourceforge.net>> >>>> > >>>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel >>>> > >>>> > >>>> > >>>> > >>>> > -- >>>> > http://amusingprogrammer.blogspot.com/ >>>> > >>>> > >>>> > >>>> > >>>> > -- >>>> > http://amusingprogrammer.blogspot.com/ >>>> > >>>> >>>> ------------------------------------------------------------------------ >>>> > >>>> >> ------------------------------------------------------------------------- >> This SF.net email is sponsored by: Microsoft >> Defy all challenges. Microsoft(R) Visual Studio 2008. >> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ >> _______________________________________________ >> Jump-pilot-devel mailing list >> Jump-pilot-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel >> >> >> > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > _______________________________________________ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > > ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
