sorry for the late reply. Yes I think its fine to commit this - unit tests are a good thing (except I have never used them ;)
thanks stefan Am 11.01.12 19:37, schrieb Benjamin Gudehus: > I will then commit this into trunk. > > 2012/1/11 Benjamin Gudehus <hasteb...@googlemail.com > <mailto:hasteb...@googlemail.com>> > > in this case it is up to you whether to branch or not. as it is > an addition it will be easy to merge later, it's merely an > organizational decision. > > regards ede > > > here are my steps: > > 0. create eclipse project (mvn eclipse:eclipse failed, so I created > it via eclipse, only add libs in /lib) > (will not be committed to svn) > > 1. run all unittests in jumptest/junit (4 errors, 3 failures) > 2. remove file core/trunk/lib/junit.jar > 3. add file core/trunk/lib/junit.jar (version 4.10) > 4. run all unittests in jumptest/junit (4 errors, 3 failures) > > (sourcecode in core/trunk/src/jumptest builds without errors (I > didn't thought junit4 is compatible with junit3).) > > 5. add files core/trunk/src/org/openjump/test/*.java > 6. add files core/trunk/src/fixtures/*.jml > 7. run all unittests in core/trunk/src/org/openjump/test (0 errors, > 0 failures) > > 8. run ant -f etc/build.xml (build successful) > 9. run openjump (works) > > 10. modify pom.xml and update junit from 3.8 to 4.10 > 11. run mvn package -P release(build success) > 12. run openjump (works) > > If everyone is fine with my changes I will commit them. > > $ svn status > A src\org\openjump\test > A src\org\openjump\test\TestTools.java > A src\org\openjump\test\TestToolsTest.java > A src\org\openjump\test\DialogParameters.java > A src\org\openjump\test\DialogParametersTest.java > A src\org\openjump\test\package-info.java > A src\org\openjump\test\ReflectionUtils.java > A src\org\openjump\test\ReflectionUtilsTest.java > A src\fixtures > A src\fixtures\dissolve.jml > A src\fixtures\inner-ring.jml > A src\fixtures\inner-ring-invalid.jml > M pom.xml > M lib\junit.jar > > --Benjamin > > > > > ------------------------------------------------------------------------------ > Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex > infrastructure or vast IT resources to deliver seamless, secure access to > virtual desktops. With this all-in-one solution, easily deploy virtual > desktops for less than the cost of PCs and save 60% on VDI infrastructure > costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox > > > > _______________________________________________ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel ------------------------------------------------------------------------------ RSA(R) Conference 2012 Mar 27 - Feb 2 Save $400 by Jan. 27 Register now! http://p.sf.net/sfu/rsa-sfdev2dev2 _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
