Hello Varsha.
I found some problem in your changes.
Please see the function
void CEFIcon::OnIndependentKaboodleVncListnerChange(bool bRunning).
There is next code
if (pDevice->m_Attributes.m_uiIndependentVncPort != _UNDEF_VNC &&
pDevice->m_Attributes.m_uiIndependentVncPort != _NO_VNC_RUN)
{
...
PostEFMessage(... MSG_UPDATE_DEVICE_PROPERTY );
}
If Kaboodle knows that independent VNC service doesn't runs,
then it have to make PostEFMessage(... MSG_UPDATE_DEVICE_PROPERTY ) also.
Therefore there have to be next code
if (pDevice->m_Attributes.m_uiIndependentVncPort != _UNDEF_VNC )
{
...
}
I have inserted that modification.- Igor ----- Original Message ----- From: "mailbox" <[EMAIL PROTECTED]> To: "Igor Kotelevsky" <[EMAIL PROTECTED]>; "Scott C. Best" <[EMAIL PROTECTED]> Cc: "Kaboodle-devel" <[EMAIL PROTECTED]> Sent: Saturday, August 17, 2002 12:58 PM Subject: Re: [Kaboodle-devel] "VNC halo" bug > Hello Igor, > I have removed the duplication. Igor Please test the correctness of the > code. > > Regards, > Varsha > ----- Original Message ----- > From: "Igor Kotelevsky" <[EMAIL PROTECTED]> > To: "Scott C. Best" <[EMAIL PROTECTED]>; "mailbox" <[EMAIL PROTECTED]> > Cc: "Kaboodle-devel" <[EMAIL PROTECTED]> > Sent: Friday, August 16, 2002 4:55 PM > Subject: [Kaboodle-devel] "VNC halo" bug > > > > Hello Scott. > > I found that "VNC halo" bug is my bug. > > That bug fixed. > > > > I visited > > http://www.geocrawler.com/lists/3/SourceForge/16728/0/9330591/ > > and found following: > > > Regarding the VNC status display synchronization: > > > I have added the synchronization, which will display the VNC halo icon. > > > For this to work I have added the flag to kaboodlebase.h as the data for > > VNC > > > comes from the registry. > > I understand that Varsha also fixed that bug. > > > > But here is next problem. > > Kaboodle already had data, which described independent VNC service. > > That data was > > CNIDDevice::m_Attributes.m_uiIndependentVncPort. > > It is the port number of independent VNC Server: > > _UNDEF_VNC - we don't know about VNC Server, > > _NO_VNC_RUN - VNC Server don't run, > > otherwise - port number of independent VNC Server. > > Now Kaboodle has new binary flag PC_RUNNING_VNC, > > which also describes above data. > > > > Therefore redundancy of data appears. > > That redundancy is a potential source of mistakes. > > I prefer to avoid that redundancy. > > I can remove the flag PC_RUNNING_VNC and avoid that redundancy. > > Please let me know if I have to make that. > > > > - Igor > > > > > > > > > > ------------------------------------------------------- > > This sf.net email is sponsored by: OSDN - Tired of that same old > > cell phone? Get a new here for FREE! > > https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390 > > _______________________________________________ > > Kaboodle-devel mailing list > > [EMAIL PROTECTED] > > https://lists.sourceforge.net/lists/listinfo/kaboodle-devel > > > > ------------------------------------------------------- This sf.net email is sponsored by: OSDN - Tired of that same old cell phone? Get a new here for FREE! https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390 _______________________________________________ Kaboodle-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/kaboodle-devel
