[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230156#comment-13230156
]
Prashanth Menon commented on KAFKA-49:
--------------------------------------
Better late than never. A second review is always a plus! To your points:
1. Absolutely, this was overlooked. Expect patch later tonight or tomorrow.
2. The DefaultEventHandler does wait for the ack by waiting for the response.
Unfortunately, the current SyncProduer doesn't timeout correctly for which
KAFKA-305 was created.
3. KafkaApis does not explicitly do the check, instead relying on LogManager
which currently does. It makes sense to move that piece of logic along with
the TODO from LogManager into KafkaApis for clarity and to separate ZK from
LogManager.
What do you think?
> Add acknowledgement to the produce request.
> -------------------------------------------
>
> Key: KAFKA-49
> URL: https://issues.apache.org/jira/browse/KAFKA-49
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Prashanth Menon
> Fix For: 0.8
>
> Attachments: KAFKA-49-v1.patch, KAFKA-49-v2.patch, KAFKA-49-v3.patch
>
>
> Currently, the produce request doesn't get acknowledged. We need to have a
> broker send a response to the producer and have the producer wait for the
> response before sending the next request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
