[
https://issues.apache.org/jira/browse/KAFKA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436784#comment-13436784
]
Neha Narkhede commented on KAFKA-351:
-------------------------------------
Thanks for rebasing Jun! But I still couldn't apply the patch on the latest
0.8. I'm actually ok with reviewing on a slightly older version. Please could
you specify which version your v3 patch applies cleanly on ?
nnarkhed-ld:kafka-351 nnarkhed$ patch -p0 -i
~/Projects/kafka-patches/kafka-351_v3.patch
patching file system_test/single_host_multi_brokers/bin/run-test.sh
patching file core/src/test/scala/unit/kafka/utils/TestUtils.scala
patching file core/src/test/scala/unit/kafka/log/LogOffsetTest.scala
patching file core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala
Hunk #2 FAILED at 98.
Hunk #3 succeeded at 116 (offset -2 lines).
Hunk #4 succeeded at 131 (offset -2 lines).
1 out of 4 hunks FAILED -- saving rejects to file
core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala.rej
patching file core/src/test/scala/unit/kafka/producer/SyncProducerTest.scala
patching file core/src/test/scala/unit/kafka/server/ISRExpirationTest.scala
patching file core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala
patching file
core/src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala
patching file core/src/test/scala/unit/kafka/consumer/TopicCountTest.scala
patching file
core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala
patching file core/src/main/scala/kafka/cluster/Replica.scala
patching file core/src/main/scala/kafka/cluster/Partition.scala
patching file core/src/main/scala/kafka/producer/BrokerPartitionInfo.scala
patching file core/src/main/scala/kafka/producer/async/DefaultEventHandler.scala
patching file core/src/main/scala/kafka/server/KafkaZooKeeper.scala
patching file core/src/main/scala/kafka/server/KafkaServer.scala
patching file core/src/main/scala/kafka/server/ReplicaFetcherThread.scala
patching file core/src/main/scala/kafka/server/ReplicaManager.scala
Hunk #2 FAILED at 66.
1 out of 2 hunks FAILED -- saving rejects to file
core/src/main/scala/kafka/server/ReplicaManager.scala.rej
patching file core/src/main/scala/kafka/server/KafkaApis.scala
Hunk #1 FAILED at 21.
Hunk #2 FAILED at 32.
Hunk #3 FAILED at 70.
Hunk #4 succeeded at 118 with fuzz 1 (offset -11 lines).
Hunk #5 succeeded at 206 with fuzz 1 (offset -19 lines).
Hunk #6 succeeded at 289 (offset -23 lines).
Hunk #7 succeeded at 311 (offset -25 lines).
Hunk #8 succeeded at 327 (offset -25 lines).
Hunk #9 FAILED at 365.
Hunk #10 FAILED at 397.
Hunk #11 succeeded at 390 with fuzz 1 (offset -30 lines).
Hunk #12 FAILED at 445.
Hunk #13 FAILED at 603.
7 out of 13 hunks FAILED -- saving rejects to file
core/src/main/scala/kafka/server/KafkaApis.scala.rej
patching file core/src/main/scala/kafka/api/LeaderAndISRResponse.scala
> Refactor some new components introduced for replication
> --------------------------------------------------------
>
> Key: KAFKA-351
> URL: https://issues.apache.org/jira/browse/KAFKA-351
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: Jun Rao
> Labels: optimization
> Fix For: 0.8
>
> Attachments: kafka-351_v1.patch, kafka-351_v2.patch,
> kafka-351_v3.patch
>
>
> Jay had some good refactoring suggestions as part of the review for KAFKA-46.
> I'd like to file this umbrella JIRA with individual sub tasks to cover those
> suggestions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
