[
https://issues.apache.org/jira/browse/KAFKA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438852#comment-13438852
]
Neha Narkhede commented on KAFKA-351:
-------------------------------------
+1
Minor comments before checking it in -
1. Fix comment in UnknownTopicOrPartitionException.scala. Right now it
describes InvalidPartitionException
2. Replica - Fix error message "shouldn't set logEndOffset for replica %d topic
%s partition %d since it's local" to first letter capital
> Refactor some new components introduced for replication
> --------------------------------------------------------
>
> Key: KAFKA-351
> URL: https://issues.apache.org/jira/browse/KAFKA-351
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: Jun Rao
> Labels: optimization
> Fix For: 0.8
>
> Attachments: kafka-351_v1.patch, kafka-351_v2.patch,
> kafka-351_v3.patch, kafka-351_v4.patch, kafka-351_v5.patch, kafka-351_v6.patch
>
>
> Jay had some good refactoring suggestions as part of the review for KAFKA-46.
> I'd like to file this umbrella JIRA with individual sub tasks to cover those
> suggestions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
