[
https://issues.apache.org/jira/browse/KAFKA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-351:
--------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks for the review. Addressed the issues in the last review and committed to
0.8.
Create kafka-476 to track using Option in Pool.
For priviate[this] var, it restricts the usage of a member field to only this
instance of the class. This way, one is always forced to use the public api to
access the member field in other instances of the class.
Yes, Intellij seems to have an issue finding references of x_=(), which is
inconvenient. Not sure if it has been addressed in a new version.
> Refactor some new components introduced for replication
> --------------------------------------------------------
>
> Key: KAFKA-351
> URL: https://issues.apache.org/jira/browse/KAFKA-351
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: Jun Rao
> Labels: optimization
> Fix For: 0.8
>
> Attachments: kafka-351_v1.patch, kafka-351_v2.patch,
> kafka-351_v3.patch, kafka-351_v4.patch, kafka-351_v5.patch, kafka-351_v6.patch
>
>
> Jay had some good refactoring suggestions as part of the review for KAFKA-46.
> I'd like to file this umbrella JIRA with individual sub tasks to cover those
> suggestions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
