[
https://issues.apache.org/jira/browse/KAFKA-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438789#comment-13438789
]
Jun Rao commented on KAFKA-475:
-------------------------------
Thanks for patch v1. Some comments:
1. The condition for testing whether we should roll a new log segment doesn't
seem right. Currently, it will roll a new segment if the last segment hasn't
been updated for retention time. What we should do is to roll a new segment
every retention interval independent of the last update time, as long as (a) no
segment has been rolled since the last retention interval; (b) the last segment
has a size larger than 0.
2. We should add a unit test to test rolling a new segment by time.
> Time based log segment rollout
> ------------------------------
>
> Key: KAFKA-475
> URL: https://issues.apache.org/jira/browse/KAFKA-475
> Project: Kafka
> Issue Type: New Feature
> Affects Versions: 0.7.1
> Reporter: Swapnil Ghike
> Assignee: Swapnil Ghike
> Labels: features
> Fix For: 0.7.2
>
> Attachments: kafka-475-v1.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Some applications might want their data to be deleted from the Kafka servers
> earlier than the default retention time.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
