[ 
https://issues.apache.org/jira/browse/KAFKA-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440519#comment-13440519
 ] 

Swapnil Ghike commented on KAFKA-475:
-------------------------------------

1. Similarly, should we also add topic level log retention size?
2. Ok.
3. Ok. I am actually changing it to a var because there is one small change to 
be made to the rolling policy - We don't roll a new log when the previous 
segment which has expired in time is empty. When a new message is finally 
appended to this empty expired segment, its timeOfCreation should also be reset 
to a new value.
4. I implemented the new tests to make sure that the independent mechanisms of 
roll and recovery don't interfere with each other. But now that I look at them, 
they indeed look like a working module of rolling followed by a working model 
of recovery. We can either remove them, or I can try to combine all modes of 
roll and recovery in one new test to check for any interference.

Also, should we have a check for illegal values in getTopic* methods in Utils?
                
> Time based log segment rollout
> ------------------------------
>
>                 Key: KAFKA-475
>                 URL: https://issues.apache.org/jira/browse/KAFKA-475
>             Project: Kafka
>          Issue Type: New Feature
>    Affects Versions: 0.7.1
>            Reporter: Swapnil Ghike
>            Assignee: Swapnil Ghike
>              Labels: features
>             Fix For: 0.7.2
>
>         Attachments: kafka-475-v1.patch, kafka-475-v2.patch, 
> kafka-475-v3.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Some applications might want their data to be deleted from the Kafka servers 
> earlier than the default retention time. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to