[
https://issues.apache.org/jira/browse/KAFKA-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440342#comment-13440342
]
Jun Rao commented on KAFKA-475:
-------------------------------
Thanks for patch v3. A few other comments:
20. KafkaConfig:
20.1 To be consistent, we probably should add topic level log file size for
rolling.
20.2 We probably don't need to cap logRoll and logRetention hours at 24*7 since
we store ms in long, which has 2^^63 millseconds.
21. LogSegment: Unlike java, we can just have "val startTime" and use it
directly. Scala already wraps the val with a public getter.
22. LogManagerTest: It seems to me that we can test log rolling (covered in
LogTest) and log cleanup (covered in LogManager) independently. Is there any
value in testing all 4 combination of log rolling and log cleanup?
> Time based log segment rollout
> ------------------------------
>
> Key: KAFKA-475
> URL: https://issues.apache.org/jira/browse/KAFKA-475
> Project: Kafka
> Issue Type: New Feature
> Affects Versions: 0.7.1
> Reporter: Swapnil Ghike
> Assignee: Swapnil Ghike
> Labels: features
> Fix For: 0.7.2
>
> Attachments: kafka-475-v1.patch, kafka-475-v2.patch,
> kafka-475-v3.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Some applications might want their data to be deleted from the Kafka servers
> earlier than the default retention time.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
