[ https://issues.apache.org/jira/browse/KAFKA-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473840#comment-13473840 ]
Neha Narkhede commented on KAFKA-548: ------------------------------------- Thanks for the patch. Few review comments - 1. We also need to make the producer side changes 2. Let's conform to coding conventions. A number of places (TopicData, KafkaApis), the open bracket is on the next line instead of same line - + fetchRequest.requestInfo.map + { should be fetchRequest.requestInfo.map { > remove partition from ProducerRequestPartitionData and > FetchResponsePartitionData > --------------------------------------------------------------------------------- > > Key: KAFKA-548 > URL: https://issues.apache.org/jira/browse/KAFKA-548 > Project: Kafka > Issue Type: Improvement > Reporter: Joe Stein > Labels: optimization > Fix For: 0.8 > > Attachments: kafka_548_v1.diff > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira