[
https://issues.apache.org/jira/browse/KAFKA-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475179#comment-13475179
]
Neha Narkhede commented on KAFKA-548:
-------------------------------------
Thanks for patch v2, here are few review comments to address before uploading a
rebased patch -
1. ConsumerFetcherThread
1.1 Can we change getPartitionTopicInfo to take in TopicAndPartition instead of
converting the input topicAndPartition back to a tuple ?
2. FetchResponse, KafkaApis
Fix the location of the brackets
3. AbstractFetcherThread
Pass in topicAndPartition to handleOffsetOutOfRange, since you re-create
another TopicAndPartition object inside that API anyways.
> remove partition from ProducerRequestPartitionData and
> FetchResponsePartitionData
> ---------------------------------------------------------------------------------
>
> Key: KAFKA-548
> URL: https://issues.apache.org/jira/browse/KAFKA-548
> Project: Kafka
> Issue Type: Improvement
> Reporter: Joe Stein
> Labels: optimization
> Fix For: 0.8
>
> Attachments: kafka_548_v1.diff, kafka_548_v2.diff
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
