[ https://issues.apache.org/jira/browse/KAFKA-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475157#comment-13475157 ]
Joel Koshy commented on KAFKA-548: ---------------------------------- Took a quick look at v2. Looks good. Can you: (i) Rebase, and wrap the long lines (there are a few). (ii) Address the coding convention issues that Neha brought up? > remove partition from ProducerRequestPartitionData and > FetchResponsePartitionData > --------------------------------------------------------------------------------- > > Key: KAFKA-548 > URL: https://issues.apache.org/jira/browse/KAFKA-548 > Project: Kafka > Issue Type: Improvement > Reporter: Joe Stein > Labels: optimization > Fix For: 0.8 > > Attachments: kafka_548_v1.diff, kafka_548_v2.diff > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira