https://bugs.kde.org/show_bug.cgi?id=386846
--- Comment #16 from Vova Mshanetskiy <vovams...@gmail.com> --- I think we are talking about different bugs now... What you seem to be trying to fix is high CPU usage *during* the animation. What i (and probably most people in the original bug 381000) was talking about is that CPU usage does not drops *after* the animation has finished. For me the cross-fade animation in Plasma Shell produces around 15% of CPU usage with Animators (4-core CPU). This may be sub-optimal, but not a big deal for me, since wallpapers do not change too often. I remember that you said that some progress indicator is also affected. This may be worse, because it may be meant to be animating much longer then a wallpaper cross-fade. It looks like some people in bug 381000 experience even higher CPU usage, so this may be a problem. However, this is a different problem. The problem i was talking about is that Plasma Shell *always* uses around 7-10% CPU while wallpaper is set to slideshow, even when cross-fade animation is not running. Plasma Shell just keeps redrawing forever. The .qml file i created earlier (attachment 108642) manages to reproduce persistent redraws while the animation is *not* running, but it produces much lower CPU usage than Plasma. It's around 2-4% on my system. That being said, i have tried your patch. I was only able to try it with attachment 108642 (with duration changed from 2000 to 200000) but there was no noticeable difference. Both consumed around 2-4% during animation. Persistent redrawing, triggered by a double click, was not fixed either. I was not able to run Plasma Shell with patched libraries because when i try to run it i get an error: $ env LD_LIBRARY_PATH=~/myqt/install/lib plasmashell plasmashell: /home/vovams/myqt/install/lib/libQt5Core.so.5: version `Qt_5.9.2_PRIVATE_API' not found (required by /usr/lib64/libKF5Declarative.so.5) Actually i think that i might be unable help you with testing CPU usage *during* animation, because replacing Animators with Animations does not reduce CPU usage *during* animation for me. It does fix persistent redraws and thus reduces CPU usage to 0 when animation is *not* running. Please look again at my comment 13. I believe we have found the reason behind persistent redraws. It looks like QQuickAnimatorController::animationFinished() is never called for canceled animation (i.e. after the second click in bug.qml window). -- You are receiving this mail because: You are watching all bug changes.
