https://bugs.kde.org/show_bug.cgi?id=352395
Ivo Raisr <iv...@ivosh.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |iv...@ivosh.net
--- Comment #7 from Ivo Raisr <iv...@ivosh.net> ---
I had a look and overall it looks pretty good.
However 'pushd/popd' is a bash'ism and won't work in other shells.
Please can you try this also under shells, for example ksh?
What happens (and what is the version) if this is run not inside a SVN/GIT
repository? For example one can run 'make dist', take the tarball, unpack it
somewhere else and build the stuff again.
Also this construct:
"if test -d .svn; then svnversion -n .; elif test -d .git; then git svn info |
\
grep ^Revision | cut -d ' ' -f2 | tr -d '\n'; fi"
can be reused, for example through a Makefile variable:
EXTRACT_SVN_VERSION = "<above>"
vgversion.h:
...
... $(shell $(EXTRACT_SVN_VERSION)) ...
--
You are receiving this mail because:
You are watching all bug changes.
