https://bugs.kde.org/show_bug.cgi?id=352395
--- Comment #10 from austinengl...@gmail.com <austinengl...@gmail.com> --- (In reply to Ivo Raisr from comment #7) > I had a look and overall it looks pretty good. > However 'pushd/popd' is a bash'ism and won't work in other shells. > Please can you try this also under shells, for example ksh? Thanks, fixed. > What happens (and what is the version) if this is run not inside a SVN/GIT > repository? For example one can run 'make dist', take the tarball, unpack it > somewhere else and build the stuff again. The svn revisions are empty. E.g., in the case of an SVN/git svn checkout: austin@austin2:~/src/valgrind$ ./vg-in-place -v --version valgrind-3.12.0.SVN-16106M-vex-3283 austin@austin2:~/src/valgrind$ ./vg-in-place --version valgrind-3.12.0.SVN and not: austin@austin2:~/src/valgrind$ ./vg-in-place -v --version valgrind-3.12.0.SVN--vex- austin@austin2:~/src/valgrind$ ./vg-in-place --version valgrind-3.12.0.SVN > Also this construct: > "if test -d .svn; then svnversion -n .; elif test -d .git; then git svn info > | \ > grep ^Revision | cut -d ' ' -f2 | tr -d '\n'; fi" > can be reused, for example through a Makefile variable: > > EXTRACT_SVN_VERSION = "<above>" > vgversion.h: > ... > ... $(shell $(EXTRACT_SVN_VERSION)) ... Thanks. I had trouble getting that working for a while. The variable contents should NOT be quoted, then it works :) -- You are receiving this mail because: You are watching all bug changes.
