https://bugs.kde.org/show_bug.cgi?id=352395

--- Comment #17 from Austin English <austinengl...@gmail.com> ---
(In reply to Philippe Waroquiers from comment #16)
> Created attachment 102468 [details]
> try 6 : modified to have vgversion.h also handled as part of make dist
> 
> Changed compared to try5:
> * vgversion.h make or update logic moved
>       from Makefile.am to auxprogs/make_or_upd_vgversion_h
> * added dist-hook to copy vgversion.h
> 
> I have tested this (on linux debian 8 amd64) in a 'in place' build,
> and  in a build from a make dist. I have checked that the dist contains
> vgversion.h. I have also tested that outside svn, vgversion.h is created
> with unknown svn versions, but that it is not replaced if it already exists.
> 
> Would be nice to do some more tests before commit
> (e.g. on other OS solaris, macos)

Thanks for working on that Philippe!

You've got a syntax error here:

+    elif [ -d .git/svn ]
+        git svn info $1 | grep '^Revision' | cut -d ' ' -f2 | tr -d '\n'
+    then
+        echo "unknown"
+    fi    
+}

should be elif ; then ; else

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to