Il giorno Wed, 5 Jul 2017 22:54:50 +0200 (CEST) Boudewijn Rempt <b...@valdyas.org> ha scritto:
> I suck at code review, personally... I can only see what's wrong with > code once I get a bug report and have to fix the code. If someone tries to ship you code that does not compile, you'll notice that, though. ;) I meant at least for the process to catch the most obvious errors: 1. Compile errors (see the kio-stash review thread) 2. Failing tests (again see that thread) 3. Obvious licensing issues (makes the life of a downstream easier) 4. Improper i18n/l10n setup -- Luca Beltrame - KDE Forums team GPG key ID: A29D259B
pgpLVIQ_LjE0s.pgp
Description: Firma digitale OpenPGP
