----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/#review19565 -----------------------------------------------------------
konqueror/src/konqsessionmanager.cpp <http://git.reviewboard.kde.org/r/106503/#comment15547> i18n: what do these "filter-..." contexts mean? konqueror/src/konqsessionmanager.cpp <http://git.reviewboard.kde.org/r/106503/#comment15544> KIcon icon("dialog-warning"); is enough, pixmap() should load the correct icon. konqueror/src/konqsessionmanager.cpp <http://git.reviewboard.kde.org/r/106503/#comment15545> i18n: remove the space before the question mark, please - Pino Toscano On Sept. 28, 2012, 4:45 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106503/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2012, 4:45 p.m.) > > > Review request for KDE Base Apps and David Faure. > > > Description > ------- > > The attached patch fixes one of those pet peeve bugs that infurate me from > time to time by allowing me to unselect the sessions I do not want to be > restored when Konqueror's restore session dialog pops up. > > > This addresses bug 260282. > http://bugs.kde.org/show_bug.cgi?id=260282 > > > Diffs > ----- > > konqueror/src/konqsessionmanager.h ee629e4 > konqueror/src/konqsessionmanager.cpp 68a003f > > Diff: http://git.reviewboard.kde.org/r/106503/diff/ > > > Testing > ------- > > * Unselected sessions should not be restored. > * If all available sessions are selected (the default), the behavior should > remain the same as it is today. > * If all available sessions are unselected, disable the "Restore Session" > button. > > > Screenshots > ----------- > > old restore dialog > http://git.reviewboard.kde.org/r/106503/s/729/ > new restore dialog > http://git.reviewboard.kde.org/r/106503/s/731/ > new restore dialog v2 > http://git.reviewboard.kde.org/r/106503/s/739/ > > > Thanks, > > Dawit Alemayehu > >
