> On Sept. 29, 2012, 9:20 a.m., David Faure wrote: > > konqueror/src/konqsessionmanager.cpp, line 450 > > <http://git.reviewboard.kde.org/r/106503/diff/3/?file=87618#file87618line450> > > > > Doesn't this lose ItemIsSelectable? I guess item->flags() | > > Qt::ItemIsUserCheckable would be better. > > Dawit Alemayehu wrote: > I did this on purpose. I do not want the items to be selectable. I just > want them to be checkable.
Ah, OK. No problem then -- assuming one can still use the keyboard to navigate this dialog. [which doesn't require selection, but at least current-index navigation] - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/#review19563 ----------------------------------------------------------- On Oct. 1, 2012, 8:56 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106503/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2012, 8:56 p.m.) > > > Review request for KDE Base Apps and David Faure. > > > Description > ------- > > The attached patch fixes one of those pet peeve bugs that infurate me from > time to time by allowing me to unselect the sessions I do not want to be > restored when Konqueror's restore session dialog pops up. > > > This addresses bug 260282. > http://bugs.kde.org/show_bug.cgi?id=260282 > > > Diffs > ----- > > konqueror/src/konqsessionmanager.cpp 68a003f > konqueror/src/konqsessionmanager.h ee629e4 > > Diff: http://git.reviewboard.kde.org/r/106503/diff/ > > > Testing > ------- > > * Unselected sessions should not be restored. > * If all available sessions are selected (the default), the behavior should > remain the same as it is today. > * If all available sessions are unselected, disable the "Restore Session" > button. > > > Screenshots > ----------- > > old restore dialog > http://git.reviewboard.kde.org/r/106503/s/729/ > new restore dialog > http://git.reviewboard.kde.org/r/106503/s/731/ > new restore dialog v2 > http://git.reviewboard.kde.org/r/106503/s/739/ > new restore dialog v3 > http://git.reviewboard.kde.org/r/106503/s/750/ > > > Thanks, > > Dawit Alemayehu > >
