-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106503/
-----------------------------------------------------------
(Updated Oct. 1, 2012, 8:56 p.m.)
Review request for KDE Base Apps and David Faure.
Changes
-------
- Changed the code that shows the session dialog into its own KDialog instance.
- Changed the top level entry item to be checkable so that it can be checked or
unchecked when the user select or unselect all the session entries underneath
it.
- Updated the rest of the code accordingly.
Description
-------
The attached patch fixes one of those pet peeve bugs that infurate me from time
to time by allowing me to unselect the sessions I do not want to be restored
when Konqueror's restore session dialog pops up.
This addresses bug 260282.
http://bugs.kde.org/show_bug.cgi?id=260282
Diffs (updated)
-----
konqueror/src/konqsessionmanager.cpp 68a003f
konqueror/src/konqsessionmanager.h ee629e4
Diff: http://git.reviewboard.kde.org/r/106503/diff/
Testing
-------
* Unselected sessions should not be restored.
* If all available sessions are selected (the default), the behavior should
remain the same as it is today.
* If all available sessions are unselected, disable the "Restore Session"
button.
Screenshots (updated)
-----------
old restore dialog
http://git.reviewboard.kde.org/r/106503/s/729/
new restore dialog
http://git.reviewboard.kde.org/r/106503/s/731/
new restore dialog v2
http://git.reviewboard.kde.org/r/106503/s/739/
new restore dialog v3
http://git.reviewboard.kde.org/r/106503/s/750/
Thanks,
Dawit Alemayehu
