----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110327/ -----------------------------------------------------------
(Updated May 14, 2013, 4:31 p.m.) Review request for Dolphin, Kate and kdelibs. Changes ------- Add back the icon, but hide it by default and introduce an "icon" property to let users define it. Description ------- This avoids confusion between the decoration icon and the close button, especially when type is KMessageWidget::Error. This happens for example with Dolphin when an error happens while trying to connect to an non available host. This change also has the nice side-effect of leaving more space for the widget text. Diffs (updated) ----- kdeui/widgets/kmessagewidget.h 80a9980e0af63185e032ca759800bb9fb32b1557 kdeui/widgets/kmessagewidget.cpp 724da0fa60a7b236d61685257e011fc49a30c1ff Diff: http://git.reviewboard.kde.org/r/110327/diff/ Testing ------- Tested with kmessagewidgetdemo, Dolphin and Kate. Thanks, Aurélien Gâteau
