----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110327/#review32512 -----------------------------------------------------------
Ship it! Given the posted screenshot, setting a unique icon is certainly a plus, since the colored background already serves as incident indicator (like a very heavily blurred watermark ;-) but this way actually even diminishes the related icon (the yellow triangle is rather lost on the yellow background and a disk or folder would work much better and provide additional information) kdeui/widgets/kmessagewidget.cpp <http://git.reviewboard.kde.org/r/110327/#comment24180> Swap in case this is called on a shown dialog? I'm at hand not sure how smart Qt is on activating the layout + if the icon needs to be loaded and there was one and there's a "longer" delay, you'd briefly see the old one (-> flicker) - at best shadowed by the compositor. - Thomas Lübking On May 14, 2013, 2:31 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110327/ > ----------------------------------------------------------- > > (Updated May 14, 2013, 2:31 p.m.) > > > Review request for Dolphin, Kate and kdelibs. > > > Description > ------- > > This avoids confusion between the decoration icon and the close button, > especially when type is KMessageWidget::Error. This happens for example with > Dolphin when an error happens while trying to connect to an non available > host. > This change also has the nice side-effect of leaving more space for the > widget text. > > > Diffs > ----- > > kdeui/widgets/kmessagewidget.h 80a9980e0af63185e032ca759800bb9fb32b1557 > kdeui/widgets/kmessagewidget.cpp 724da0fa60a7b236d61685257e011fc49a30c1ff > > Diff: http://git.reviewboard.kde.org/r/110327/diff/ > > > Testing > ------- > > Tested with kmessagewidgetdemo, Dolphin and Kate. > > > Thanks, > > Aurélien Gâteau > >