----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112068/#review37740 -----------------------------------------------------------
Don't put QChar in your structures. That makes them non-POD. Use ushort only. Try to find an alternative to the structure containing QString too (as in, removing the QString). - Thiago Macieira On Aug. 13, 2013, 10:01 p.m., Thomas Fischer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112068/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2013, 10:01 p.m.) > > > Review request for kdelibs and KDE Utils. > > > Description > ------- > > Attached patch tries to determine the LaTeX command sequence for a given > Unicode character. Right now, the most common latin-based characters and > selected symbols are covered. > The translation table is based on the source code used in KBibTeX (BibTeX > editor) and corrections/updates can be easily shared between both projects. > > > Diffs > ----- > > kdeui/widgets/kcharselect.h de9e184 > kdeui/widgets/kcharselectdata.cpp 41eab5b > kdeui/widgets/kcharselectdata_p.h c6f7a3a > > Diff: http://git.reviewboard.kde.org/r/112068/diff/ > > > Testing > ------- > > > Thanks, > > Thomas Fischer > >
