----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112068/#review39970 -----------------------------------------------------------
Sorry that i reply that late. :/ I would be very happy to see that feature in KCharSelect. Christoph was right, my first thought was that this should be in the data file and not in the C++ code. However, after thinking a while about it, I'm not so sure any more. The problem is not that the other data comes from unicode.org -- there is no reason to not add other sources. But I assume that this will make the syncing with KBibTeX more difficult (because it means porting it to Python). Additionally, there are not too many LaTeX characters and putting it in the data file will cause overhead for every Unicode character, so it might not be worth it. So from my side, I think it looks good and keeping it as C++ seems to be a good option. I don't have a development setup right now and I don't want to say "Ship it" without being able to compile and test, but from me there are no objections. :) - Daniel Laidig On Aug. 16, 2013, 7:16 p.m., Thomas Fischer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112068/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2013, 7:16 p.m.) > > > Review request for kdelibs, KDE Utils and Daniel Laidig. > > > Description > ------- > > Attached patch tries to determine the LaTeX command sequence for a given > Unicode character. Right now, the most common latin-based characters and > selected symbols are covered. > The translation table is based on the source code used in KBibTeX (BibTeX > editor) and corrections/updates can be easily shared between both projects. > > > Diffs > ----- > > kdeui/widgets/kcharselect.h de9e184 > kdeui/widgets/kcharselect.cpp e00d001 > kdeui/widgets/kcharselectdata.cpp 41eab5b > kdeui/widgets/kcharselectdata_p.h c6f7a3a > > Diff: http://git.reviewboard.kde.org/r/112068/diff/ > > > Testing > ------- > > > Thanks, > > Thomas Fischer > >
