> On Oct. 22, 2013, 9:42 a.m., David Faure wrote: > > I'm not sure how kcharselect (the program) differs from KCharSelect (the > > kdelibs class), but is there any way this could go into the program only? > > There isn't much usefulness in showing latex commands when bringing up > > KCharSelect (the class) in e.g. calligra. > > Or is kile a target use case, hence the need to have it in the kdelibs > > class? > > > > Other than that, the patch looks ok to me - provided that the target branch > > is frameworks, not master (which is frozen for large changes).
It is kdelibs which provides the widget (KCharSelect class), so it cannot be directly changed in the kcharselect program. Maybe the best option is to provide a virtual function in the KCharSelect class which returns an empty string in its default implementation. This function's return value is pasted where the LaTeX code is shown now (below the XML code, which BTW is irrelevant for Calligra users, too). The kcharselect program could have its own class which inherits KCharSelect and re-implements this virtual function to return LaTeX codes. To spin this idea further, KCharSelect could get refactored to have a simple plugin architecture, which would load the XML code or LaTeX code implemenation upon the user's request ... About the port to KF5, unfortunately I don't have the resources (time, ...) to compile it locally. Maybe someone else could take the step of porting my KDE 4.11+ code to KF5. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112068/#review42148 ----------------------------------------------------------- On Aug. 16, 2013, 9:16 p.m., Thomas Fischer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/112068/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2013, 9:16 p.m.) > > > Review request for kdelibs, KDE Utils and Daniel Laidig. > > > Repository: kdelibs > > > Description > ------- > > Attached patch tries to determine the LaTeX command sequence for a given > Unicode character. Right now, the most common latin-based characters and > selected symbols are covered. > The translation table is based on the source code used in KBibTeX (BibTeX > editor) and corrections/updates can be easily shared between both projects. > > > Diffs > ----- > > kdeui/widgets/kcharselect.h de9e184 > kdeui/widgets/kcharselect.cpp e00d001 > kdeui/widgets/kcharselectdata.cpp 41eab5b > kdeui/widgets/kcharselectdata_p.h c6f7a3a > > Diff: https://git.reviewboard.kde.org/r/112068/diff/ > > > Testing > ------- > > > Thanks, > > Thomas Fischer > >
