----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/#review41886 -----------------------------------------------------------
The patch doesn't apply cleanly to KDE/4.11 branch - it looks reasonable to me. If you correct that patch I can double-check it builds here. - Kurt Hindenburg On Sept. 29, 2013, 5:15 p.m., Gilles Caulier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112991/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2013, 5:15 p.m.) > > > Review request for kde-workspace. > > > Bugs: https://trac.macports.org/ticket/33780 > http://bugs.kde.org/show_bug.cgi?id=https://trac.macports.org/ticket/33780 > > > Repository: kde-workspace > > > Description > ------- > > This patch fix broken compilation under OSX / macports about kde-workspace. > > Patch do not touch implementation. Only compilation rules are changed in > cmake script to follow the way way than Windows rules, where no X11 lib are > available. > > By this way, Oxygen is compiled and installed to macport and digiKam has a > suitable GUI under OSX. > > See my Macports bug report for details : > https://trac.macports.org/ticket/33780 > > Gilles Caulier > > > Diffs > ----- > > CMakeLists.txt c37ab8b > kcontrol/CMakeLists.txt a25aaa0 > libs/CMakeLists.txt 9d71a03 > > Diff: http://git.reviewboard.kde.org/r/112991/diff/ > > > Testing > ------- > > I tested this patch under my macbook pro, using a fresh install of Macports > (KDE 4.11.1 / Qt 4.8.5) > > As kde-workspace macports package is broken, i checkout code from KDE > git/master repository and fixed compilation rules as well. > > > Thanks, > > Gilles Caulier > >