> On Oct. 17, 2013, 5:11 p.m., Gilles Caulier wrote: > > Ok, thanks for you feedback. > > > > I make patch with git/master, not KDE/4.11 branch. I will checkout this > > code and adapt patch accordingly > > > > Gilles Caulier
> I make patch with git/master, not KDE/4.11 branch You are aware that master is Qt5 based and will not result in a 4.12 release? If your aim is to fix it for the next release KDE/4.11 is the better branch, for master the situation is different anyway as our basic assumption unix == X11 is no longer valid. Also it's probably too early to put any non-linux adjustments into master - the chances that it breaks is rather high given that only Linux developers are working on it right now. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/#review41897 ----------------------------------------------------------- On Sept. 29, 2013, 7:15 p.m., Gilles Caulier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112991/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2013, 7:15 p.m.) > > > Review request for kde-workspace. > > > Bugs: https://trac.macports.org/ticket/33780 > http://bugs.kde.org/show_bug.cgi?id=https://trac.macports.org/ticket/33780 > > > Repository: kde-workspace > > > Description > ------- > > This patch fix broken compilation under OSX / macports about kde-workspace. > > Patch do not touch implementation. Only compilation rules are changed in > cmake script to follow the way way than Windows rules, where no X11 lib are > available. > > By this way, Oxygen is compiled and installed to macport and digiKam has a > suitable GUI under OSX. > > See my Macports bug report for details : > https://trac.macports.org/ticket/33780 > > Gilles Caulier > > > Diffs > ----- > > CMakeLists.txt c37ab8b > kcontrol/CMakeLists.txt a25aaa0 > libs/CMakeLists.txt 9d71a03 > > Diff: http://git.reviewboard.kde.org/r/112991/diff/ > > > Testing > ------- > > I tested this patch under my macbook pro, using a fresh install of Macports > (KDE 4.11.1 / Qt 4.8.5) > > As kde-workspace macports package is broken, i checkout code from KDE > git/master repository and fixed compilation rules as well. > > > Thanks, > > Gilles Caulier > >
