----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123797/#review80406 -----------------------------------------------------------
plasma-workspace/klipper/historyitem.cpp (line 88) <https://git.reviewboard.kde.org/r/123797/#comment55163> use .isEmpty() rather than string comparison plasma-workspace/klipper/historyitem.cpp (line 89) <https://git.reviewboard.kde.org/r/123797/#comment55164> return nullptr; - Kai Uwe Broulik On Mai 15, 2015, 2:24 nachm., Patrick Eigensatz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123797/ > ----------------------------------------------------------- > > (Updated Mai 15, 2015, 2:24 nachm.) > > > Review request for kde-workspace and Patrick Eigensatz. > > > Bugs: 192922 > http://bugs.kde.org/show_bug.cgi?id=192922 > > > Repository: kde-workspace > > > Description > ------- > > [PATCH] kde-workspace: klipper: Fix #192922 Ignore blank entries > > > QString::trimmed() is used to check if the string only consists of whitespace > characters. If it does, the creation of the HistoryStringItem fails. > > > Diffs > ----- > > plasma-workspace/klipper/historyitem.cpp e9bdec7 > > Diff: https://git.reviewboard.kde.org/r/123797/diff/ > > > Testing > ------- > > > Thanks, > > Patrick Eigensatz > >
