> On Mai 15, 2015, 2:27 nachm., Kai Uwe Broulik wrote: > > plasma-workspace/klipper/historyitem.cpp, line 89 > > <https://git.reviewboard.kde.org/r/123797/diff/1/?file=369295#file369295line89> > > > > return nullptr; > > Patrick Eigensatz wrote: > Thank you! Existing code uses everywhere "return 0;", I can't find the > declaration/definition of nullptr... > > Thomas Lübking wrote: > nullptr is a (meanwhile required) c++11 feature. You can use it now, but > could not when c++11 wasn't used. > Using nullptr is typesafe and more readable, so it should be used in new > code. > > Patrick Eigensatz wrote: > Thank you Thomas! I just found out, sorry for only searching klipper's > code. Issue is now resolved for every appearance in klipper.
Please ensure to do this in two commits - altering the behavior is different from housekeeping. It's maybe not that relevant in this very case, but the general problem is that if somebody later on thinks: "this commit causes problems, i'll revert it", he'll accidentally revert the other changes as well, pot. running into merge conflicts etc. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123797/#review80406 ----------------------------------------------------------- On Mai 15, 2015, 2:56 nachm., Patrick Eigensatz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123797/ > ----------------------------------------------------------- > > (Updated Mai 15, 2015, 2:56 nachm.) > > > Review request for kde-workspace and Patrick Eigensatz. > > > Bugs: 192922 > http://bugs.kde.org/show_bug.cgi?id=192922 > > > Repository: kde-workspace > > > Description > ------- > > [PATCH] kde-workspace: klipper: Fix #192922 Ignore blank entries > > > QString::trimmed() is used to check if the string only consists of whitespace > characters. If it does, the creation of the HistoryStringItem fails. > > > Diffs > ----- > > plasma-workspace/klipper/history.cpp 486e8f7 > plasma-workspace/klipper/historyitem.cpp e9bdec7 > plasma-workspace/klipper/klipper.cpp cde65f5 > > Diff: https://git.reviewboard.kde.org/r/123797/diff/ > > > Testing > ------- > > > Thanks, > > Patrick Eigensatz > >
