> On May 15, 2015, 8:01 p.m., Martin Gräßlin wrote: > > This patch is against kde-workspace, but the development happens in > > plasma-workspace nowadays. Could you please rebase against the newer > > repository? > > Patrick Eigensatz wrote: > Sorry, I saw your comment a bît too late. Can you tell me how to rebase > my patch? Do I have to add another git-origin and fetch changes from there?
I think you need to clone plasma-workspace and just apply the patches using good old patch. They should (TM) apply cleanly as klipper is still a subdirectory. But it might be that internals changed. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123797/#review80412 ----------------------------------------------------------- On May 15, 2015, 8:05 p.m., Patrick Eigensatz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123797/ > ----------------------------------------------------------- > > (Updated May 15, 2015, 8:05 p.m.) > > > Review request for kde-workspace and Patrick Eigensatz. > > > Bugs: 192922 > http://bugs.kde.org/show_bug.cgi?id=192922 > > > Repository: kde-workspace > > > Description > ------- > > [PATCH] kde-workspace: klipper: Fix #192922 Ignore blank entries > > > QString::trimmed() is used to check if the string only consists of whitespace > characters. If it does, the creation of the HistoryStringItem fails. > > > Diffs > ----- > > plasma-workspace/klipper/history.cpp 486e8f7 > plasma-workspace/klipper/historyitem.cpp e9bdec7 > plasma-workspace/klipper/klipper.cpp cde65f5 > > Diff: https://git.reviewboard.kde.org/r/123797/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > The patchfile containing both commits > > https://git.reviewboard.kde.org/media/uploaded/files/2015/05/15/c938fefd-9fe6-41bf-860a-e161920669a6__patchfile.patch > > > Thanks, > > Patrick Eigensatz > >
