ok, they were at some point retrieving the icon using .desktop file
but no more.........

Paolo Borelli [gedit developer] 2014-02-20 09:39:20 UTC

this should be fixed in 7ff1b3696fee69a7adfbb82b7a8f5b2ae2932bb1

For gnome at some point the icon was retrieved from the desktop file, then in
the mean time the gnome wm stopped showing the icon and this got lost in the
shuffle.

Should be fixed with that commit

2014-02-20 10:22 GMT+02:00 Damian Ivanov <damianator...@gmail.com>:
> FYI I'll try it with the gnome bug:
> https://bugzilla.gnome.org/show_bug.cgi?id=724781
>
> 2014-02-20 8:41 GMT+02:00 Martin Gräßlin <mgraess...@kde.org>:
>> On Thursday 20 February 2014 07:36:20 Damian Ivanov wrote:
>>> It's by design. They will do this for more and more applications. The
>>> icon is specified in the .desktop file. See my other last message.
>>
>> This is irrelevant. There is no matching between .desktop file and the 
>> window.
>> As I wrote there is no hint which indicates which .desktop file belongs to 
>> the
>> window. If GNOME wants their apps to work also on other desktop shells they
>> should not remove the hints.
>>
>> Personally I don't care at all whether it's broken if they remove the
>> property. It just tells me that GNOME isn't interested in keeping their apps
>> compatible. It's great to know, that allows us to clean up the code and 
>> remove
>> everything not used by KDE </sarcasmn>
>>
>> Cheers
>> Martin
>>>
>>> Regards,
>>> Damian
>>>
>>> 2014-02-20 7:28 GMT+01:00 Martin Gräßlin <mgraess...@kde.org>:
>>> > On Thursday 20 February 2014 05:26:48 Damian Ivanov wrote:
>>> >> Hallo Thomas,
>>> >> Hallo Martin,
>>> >>
>>> >> PS (before it gets lost after the output below :-)): I'm on openSUSE
>>> >> 13.1, I looked into /usr/share/icons there is no icon called gedit but
>>> >> I'm quite convinced that in GNOME the icon which is loaded for gedit
>>> >> is /usr/share/icons/*theme*/*size*/apps/accessories-text-editor.png
>>> >>
>>> >> Gruss,
>>> >> Damian
>>> >>
>>> >> -> Can you please post the output of "xprop" for the window?
>>> >
>>> >> My pleasure:
>>> > Thanks. The output doesn't contain the icon any more. There is also
>>> > nothing in the GTK properties which I could understand as  an icon. Even
>>> > if I would not add support for something like that. Please raise a bug
>>> > against gedit.
>>> >
>>> > Cheers
>>> > Martin
>>> >
>>> >> _NET_WM_STATE(ATOM) =
>>> >> WM_STATE(WM_STATE):
>>> >> window state: Normal
>>> >> icon window: 0x0
>>> >> _NET_FRAME_EXTENTS(CARDINAL) = 1, 1, 39, 1
>>> >> _NET_WM_DESKTOP(CARDINAL) = 0
>>> >> _NET_WM_ALLOWED_ACTIONS(ATOM) = _NET_WM_ACTION_MOVE,
>>> >> _NET_WM_ACTION_RESIZE, _NET_WM_ACTION_FULLSCREEN,
>>> >> _NET_WM_ACTION_MINIMIZE, _NET_WM_ACTION_SHADE,
>>> >> _NET_WM_ACTION_MAXIMIZE_HORZ, _NET_WM_ACTION_MAXIMIZE_VERT,
>>> >> _NET_WM_ACTION_CHANGE_DESKTOP, _NET_WM_ACTION_CLOSE,
>>> >> _NET_WM_ACTION_ABOVE, _NET_WM_ACTION_BELOW
>>> >> WM_HINTS(WM_HINTS):
>>> >> Client accepts input or input focus: True
>>> >> Initial state is Normal State.
>>> >> window id # of group leader: 0x2200001
>>> >> _NET_WM_OPAQUE_REGION(CARDINAL) = 7, 0, 1557, 7, 0, 7, 1571, 858
>>> >> XdndAware(ATOM) = BITMAP
>>> >> _GTK_APP_MENU_OBJECT_PATH(UTF8_STRING) = "/org/gnome/Gedit/menus/appmenu"
>>> >> _GTK_WINDOW_OBJECT_PATH(UTF8_STRING) = "/org/gnome/Gedit/window/1"
>>> >> _GTK_APPLICATION_OBJECT_PATH(UTF8_STRING) = "/org/gnome/Gedit"
>>> >> _GTK_UNIQUE_BUS_NAME(UTF8_STRING) = ":1.593"
>>> >> _GTK_APPLICATION_ID(UTF8_STRING) = "org.gnome.Gedit"
>>> >> WM_WINDOW_ROLE(STRING) = "gedit-window-1392869512-705416-0-linux-v2xv"
>>> >> _NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_NORMAL
>>> >> _NET_WM_SYNC_REQUEST_COUNTER(CARDINAL) = 35651627, 35651628
>>> >> _NET_WM_USER_TIME_WINDOW(WINDOW): window id # 0x220002a
>>> >> WM_CLIENT_LEADER(WINDOW): window id # 0x2200001
>>> >> _NET_WM_PID(CARDINAL) = 27750
>>> >> WM_LOCALE_NAME(STRING) = "en_US.UTF-8"
>>> >> WM_CLIENT_MACHINE(STRING) = "linux-v2xv"
>>> >> WM_NORMAL_HINTS(WM_SIZE_HINTS):
>>> >> program specified minimum size: 533 by 186
>>> >> program specified base size: 0 by 0
>>> >> window gravity: NorthWest
>>> >> WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW, WM_TAKE_FOCUS,
>>> >> _NET_WM_PING, _NET_WM_SYNC_REQUEST
>>> >> WM_CLASS(STRING) = "gedit", "Gedit"
>>> >> WM_ICON_NAME(STRING) = "kwindowsystem.h (~/Downloads/kwindowsystem/src) -
>>> >> gedit" _NET_WM_ICON_NAME(UTF8_STRING) = "kwindowsystem.h
>>> >> (~/Downloads/kwindowsystem/src) - gedit"
>>> >> WM_NAME(STRING) = "kwindowsystem.h (~/Downloads/kwindowsystem/src) -
>>> >> gedit"
>>> >> _NET_WM_NAME(UTF8_STRING) = "kwindowsystem.h
>>> >> (~/Downloads/kwindowsystem/src) - gedit"
>>> >>
>>> >> 2014-02-20 1:09 GMT+02:00 Thomas Lübking <thomas.luebk...@gmail.com>:
>>> >> > On Mittwoch, 19. Februar 2014 23:19:00 CEST, Damian Ivanov wrote:
>>> >> >> Usecase: Well in kwindowsystem.h you already have stuff like
>>> >> >> minimizeWindow,unminize, raise,lower, so it would just be logical to
>>> >> >> look for it there.
>>> >> >
>>> >> > "Convenience access to certain properties and features of the window
>>> >> > manager.
>>> >> >
>>> >> > The class KWindowSystem provides information about the state of the
>>> >> > window
>>> >> > manager and allows asking the window manager to change them using a
>>> >> > more
>>> >> > high-level interface than the NETWinInfo/NETRootInfo lowlevel classes."
>>> >> >
>>> >> > I guess it was left out since "closed" is not a state of the window -
>>> >> > the
>>> >> > window's just gone.
>>> >> >
>>> >> > @Martin
>>> >> > Since NETWinInfo and NETRootInfo only deal with NETWM, abstracting more
>>> >> > functions into KWindowSystem (thus shifting its meaning a bit) might be
>>> >> > necessary reg. Wayland (and as it seems that GNOME just completeley
>>> >> > abandoned the NETWM spec...)
>>> >> >
>>> >> >> Also in kwindowsystem I pass the window to minimize/lower/raise as
>>> >> >> int. In netwm.* it doesn't take the int as argument for me.
>>> >> >
>>> >> > NETRootInfo(QX11Info::display(),
>>> >> > NET::CloseWindow).closeWindowRequest(wId);
>>> >> >
>>> >> > "Window" in NETRootInfo is (on X11!) just an alias for "WId" which is
>>> >> > NOT
>>> >> > integer (though effectively 32bit on X11, but that does not hold for
>>> >> > all
>>> >> > systems)
>>> >> >
>>> >> >> Maybe
>>> >> >> (https://mail.gnome.org/archives/commits-list/2013-March/msg07200.html
>>> >> >> )
>>> >> >> is related?
>>> >> >
>>> >> > No, but this:
>>> >> > " However with the icon property being unused anywhere else in GNOME3,
>>> >> > applications have started to not set any window icon at all."
>>> >> > pretty much explains it.
>>> >> >
>>> >> > The window likely just sets no icon (but hopefully some gnome specific
>>> >> > hint?) at all.
>>> >> >
>>> >> > -> Can you please post the output of "xprop" for the window?
>>> >> >
>>> >> > Cheers,
>>> >> > Thomas
>>> >> >
>>> >> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
>>> >> >> unsubscribe
>>> >> >> <<
>>> >>>
>>> >>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
>>> >>> unsubscribe <<>>
>>> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
>>> >> <<
>>
>>
>>>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe 
>>>> <<
>>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Reply via email to