----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/#review79979 -----------------------------------------------------------
Ship it! Good job. If the tests are also passing, then ship it! src/engine/postingdb.h (line 55) <https://git.reviewboard.kde.org/r/123662/#comment54859> Could you please rename this to 'iter' instead of 'getIter' and make it private? We like to avoid 'get' in the name of getters. src/engine/postingdb.cpp (line 295) <https://git.reviewboard.kde.org/r/123662/#comment54860> Please move this assert outside the lambda. src/engine/postingdb.cpp (line 296) <https://git.reviewboard.kde.org/r/123662/#comment54861> Maybe in a seperarate patch we want to use QByteArray::fromRawData or something and avoid the copy. Though it might just be too trivial. - Vishesh Handa On May 6, 2015, 6:28 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123662/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 6:28 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > This removes code dupication within different kinds of iterators namely: > prefix,regex, comparator iterators. > > > Diffs > ----- > > src/engine/postingdb.h fd48602 > src/engine/postingdb.cpp 8c76a72 > > Diff: https://git.reviewboard.kde.org/r/123662/diff/ > > > Testing > ------- > > Compiles and tests pass. > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<