----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/#review79986 -----------------------------------------------------------
src/engine/postingdb.h (line 55) <https://git.reviewboard.kde.org/r/123662/#comment54868> could this be made private? and then a template function and take the Validator as a template arg? this would safe the allocation for the type erasure performed by std::function. src/engine/postingdb.cpp (line 296) <https://git.reviewboard.kde.org/r/123662/#comment54869> sadly QByteArrayRef is still not there so yes this is what you'd need to do. and the performance impact can be big so definitey worth to d that in a follow-up. alternatively, couldn't you use qstrncmp or the stl/c alternative here? this is probably even faster - Milian Wolff On May 6, 2015, 6:28 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123662/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 6:28 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > This removes code dupication within different kinds of iterators namely: > prefix,regex, comparator iterators. > > > Diffs > ----- > > src/engine/postingdb.h fd48602 > src/engine/postingdb.cpp 8c76a72 > > Diff: https://git.reviewboard.kde.org/r/123662/diff/ > > > Testing > ------- > > Compiles and tests pass. > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
