> On May 7, 2015, 7:06 a.m., Milian Wolff wrote: > > src/engine/postingdb.cpp, line 324 > > <https://git.reviewboard.kde.org/r/123662/diff/3/?file=367309#file367309line324> > > > > use auto instead of Validator, otherwise you'll pay for the type erasure
oh, now I get it, std::function uses type erasure so it can store anything callable (Lambda in our case), by using templates we can pass anything callable to iter without worrying about its type. Thanks :) > On May 7, 2015, 7:06 a.m., Milian Wolff wrote: > > src/engine/postingdb.cpp, line 364 > > <https://git.reviewboard.kde.org/r/123662/diff/3/?file=367309#file367309line364> > > > > again, auto. > > > > also: take the prefixLen by value May I ask why? And regexp as reference? > On May 7, 2015, 7:06 a.m., Milian Wolff wrote: > > src/engine/postingdb.cpp, line 380 > > <https://git.reviewboard.kde.org/r/123662/diff/3/?file=367309#file367309line380> > > > > auto, tyke comVal and com by value Same as above. - Pinak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/#review80012 ----------------------------------------------------------- On May 7, 2015, 4:53 a.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123662/ > ----------------------------------------------------------- > > (Updated May 7, 2015, 4:53 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > This removes code dupication within different kinds of iterators namely: > prefix,regex, comparator iterators. > > > Diffs > ----- > > src/engine/postingdb.h fd48602 > src/engine/postingdb.cpp 8c76a72 > > Diff: https://git.reviewboard.kde.org/r/123662/diff/ > > > Testing > ------- > > Compiles and tests pass. > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
