----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/#review80026 -----------------------------------------------------------
src/engine/postingdb.cpp (line 296) <https://git.reviewboard.kde.org/r/123662/#comment54910> sorry, I was thinking comVal was something else - keep it as a reference. I actually have to research whether passing that as a value or reference is better. so keep the ref as is for the complex types that do refcounting or similar internally. for simple types like int just make it a value and it's as fast as it can only get. - Milian Wolff On May 7, 2015, 4:53 a.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123662/ > ----------------------------------------------------------- > > (Updated May 7, 2015, 4:53 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > This removes code dupication within different kinds of iterators namely: > prefix,regex, comparator iterators. > > > Diffs > ----- > > src/engine/postingdb.h fd48602 > src/engine/postingdb.cpp 8c76a72 > > Diff: https://git.reviewboard.kde.org/r/123662/diff/ > > > Testing > ------- > > Compiles and tests pass. > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
