On Sat, May 25, 2024 at 10:52 PM <christ...@cullmann.io> wrote: > On 2024-05-25 05:40, Ben Cooksley wrote: > > Hi all, > > > > Been looking into what is needed to migrate Windows CI over to Qt 6.7 > > this afternoon and alas have run into a few roadblocks, related to > > QDBusConnection. > > > > https://invent.kde.org/sysadmin/ci-management/-/jobs/1848501 > > > > https://invent.kde.org/sysadmin/ci-management/-/jobs/1848502 > > > > Not entirely sure why, but it seems that something in the way headers > > are installed for QtDBus has changed for 6.7 and Dolphin and > > kio-extras are now unhappy. > > > > Could someone take a look please? > > I think the issue is that most of our frameworks no longer requires dbus > on Windows and these apps/plugins did miss to > add explicit cmake finds/use of QDBus. >
Ouch, yes that would cause it. Understandable that we're cleaning that up, just not ideal timing :) > > I can patch that in master, actually even better I patch the use out on > that systems. > > If we need that in stable, one will need to backport that, did it > already for Kate. > If we could ensure the necessary fixes land on both master and stable that would be good - not so sure about Dolphin but i'm pretty sure kio-extras at least is used somewhere in the dependency stack as a build time dependency. > > Greetings > Christoph > Thanks, Ben > > > > > > Thanks, > > Ben >
