> On Jan. 17, 2014, 8:43 p.m., Martin Gräßlin wrote: > > this would break my workflow given that I install kde4 and kf5 to different > > prefixes. I think this needs a different approach, but please don't ask me > > for it. I'm lacking ideas how we could solve this upstream. > > Hrvoje Senjan wrote: > What about just renaming xml files? Interfaces would be left compatible, > and the files would not conflict. Only it would look a bit ugly, and possibly > confusing... > (To my knowledge, there is no rule/spec that xml must match interface > name, but that could be false ;-) > > Martin Tobias Holmedahl Sandsmark wrote: > I think the idea is to move the xml file to kde-workspace somehow? > > Jonathan Riddell wrote: > @Gräßlin How would it break the workflow? You can install kdelibs4 and > kf5 anywhere you like and it'll still compile fine. But it won't overlap > files if they are installed to the same place with these changes. > > @sandsmark yes the files would be moved into kde-workspace, see patch in > https://git.reviewboard.kde.org/r/115079/ > > Martin Gräßlin wrote: > How is a setup going to find the xml file to generate an interface from > if it doesn't get installed? A true KF5 setup shouldn't pick anything from > kdelibs4. By not installing it, things depending on it will be broken. Or am > I missing something? > > Martin Gräßlin wrote: > Oh and I think review request https://git.reviewboard.kde.org/r/115079/ > illustrates the problem. As the file doesn't get installed any more, we need > to copy it everywhere where it's going to be used. This looks like a very > sub-optimal solution. > > Jonathan Riddell wrote: > The xml file would be included in the kde-workspace source directly ( > https://git.reviewboard.kde.org/r/115079/ )
New patch follows Hrvoje Senjan's suggestion to rename the interface file but keep the interface name the same - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47614 ----------------------------------------------------------- On Jan. 21, 2014, 2:49 p.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115078/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 2:49 p.m.) > > > Review request for KDE Frameworks and Martin Gräßlin. > > > Repository: kglobalaccel > > > Description > ------- > > don't install dbus interface files in kglobalaccel, these overlap with the > equivalent files in kdelibs4 which causes problems for some distributions > > > Diffs > ----- > > src/org.kde.kglobalaccel.Component.xml ec21201 > src/org.kde.KGlobalAccel.xml 8746551 > src/kf5_org.kde.kglobalaccel.Component.xml PRE-CREATION > src/kf5_org.kde.KGlobalAccel.xml PRE-CREATION > src/CMakeLists.txt d48e92e > > Diff: https://git.reviewboard.kde.org/r/115078/diff/ > > > Testing > ------- > > > Thanks, > > Jonathan Riddell > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
