sitter added a comment.
LGTM. I do wonder if the new deprecation annotations should be used for the the deprecation though: https://api.kde.org/ecm/module/ECMGenerateExportHeader.html REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D21795 To: feverfew, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter, chinmoyr Cc: elvisangelaccio, bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns
