dfaure added inline comments. INLINE COMMENTS
> sitter wrote in Polkit1Backend.cpp:239 > Mhhhh. Mhhhhhhhh. I don't really have a suggestion here, but this is an > incredibly dangerous change. Nested event loops can cause all sorts of > negative effects. That's why the isValid had a note in the documentation, to > tell the frontend dev to be careful. By adding a new loop in existing api we > add a pit to fall into. I really don't know what can be done about it though. > Could we get by with 1 second maybe? This code is FULL of nested event loops. Does it run in a GUI process, or in some sort of separate backend process? REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D21795 To: feverfew, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter, chinmoyr Cc: elvisangelaccio, bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns
